dcc redesign: refactor TextArea and Tooltip
#3468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoolADE85
requested review from
T4rk1n,
ndrezn,
gvwilson and
emilykl
as code owners
KoolADE85
force-pushed
the
feature/dcc-refactor-textarea-tooltip
branch
from
1f7f921 to
6bb0f4a
Compare
KoolADE85
changed the title
TextArea and Tooltip
|
@T4rk1n please review |
T4rk1n
reviewed
Oct 7, 2025
Comment on lines
23
to
41
| const asNumber = (value?: string | number): number | undefined => { | ||
| return typeof value === 'string' | ||
| ? isNaN(parseInt(value, 10)) | ||
| ? undefined | ||
| : parseInt(value, 10) | ||
| : value; | ||
| }; | ||
| const asBool = (value?: string | boolean): boolean | undefined => { | ||
| if (typeof value === 'string') { | ||
| if (['true', 'TRUE', 'True'].includes(value)) { | ||
| return true; | ||
| } | ||
| if (['false', 'FALSE', 'False'].includes(value)) { | ||
| return false; | ||
| } | ||
| return undefined; | ||
| } | ||
| return value; | ||
| }; |
There was a problem hiding this comment.
I don't think those conversion are necessary, the props are transfered in json and bool and number. The prop type should be bool or number but the string interpolation makes it harder on the python type check.
There was a problem hiding this comment.
I like your idea here, and pushed up a change that removes string as an allowed type for these props.
However... these existed for API compatibility (the docs say string is allowed) so just want you to be aware of the backwards incompatibility that this introduces (especially for numeric props like cols and maxLength)
…r-textarea-tooltip' into feature/dcc-refactor-textarea-tooltip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small refactor of
TextareaandTooltipcomponents to match the current designs and be Typescript components.